feat: Ensure env-vars changes are always immediately applied#399
Open
aki-ks wants to merge 1 commit intoMailu:masterfrom
Open
feat: Ensure env-vars changes are always immediately applied#399aki-ks wants to merge 1 commit intoMailu:masterfrom
aki-ks wants to merge 1 commit intoMailu:masterfrom
Conversation
aki-ks
force-pushed
the
feature/rolling-update-on-env-var-change
branch
from
af21e83 to
1e24c79
Compare
Contributor
Author
|
Oops, I just realized that a PR containing the exact same changes was already filed as #399 almost a year ago Why wasn't it merged yet, there was not even any discussion 🤔 |
Contributor
Author
|
The Trivy check complains about flags such as |
Contributor
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
github-actions
bot
added
the
Stale
Contributor
|
@aki-ks Can you please rebase your changes to current master? |
github-actions
bot
removed
the
Stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some values of this chart only cause an update of the mailu env-var ConfigMap. Since all Mailu Pods get most of their env-vars from that ConfigMap using
envFrom, when such values are updated, these Pods keep running with the old configuration, until somebody manually restarts them.This PR adds checksum annotations to every Deployment/StatefulSet that utilizes the
ConfigMapto cause a rolling update when ever the ConfigMap is updated, to ensure that its new values are applied. (see here for detailed pattern explanation)