chore(chart): add helm chart - #673
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
2735a26 to
d4c83b7
Compare
d4c83b7 to
321add9
Compare
| @@ -0,0 +1,38 @@ | |||
| 🌊 ThreatSea has been deployed! | |||
|
|
|||
| {{- if eq .Values.config.authMethod "" }} | |||
There was a problem hiding this comment.
Wrong condition is about authMethod, but warning is about image tag
|
|
||
| # -- Origin of the frontend (used for CORS) | ||
| originApp: "" | ||
| # -- Origin of the backend (used for CORS) |
There was a problem hiding this comment.
originBackend is not just used for CORS, but also for AUTH.
| # ── Database ────────────────────────────────────────────────── | ||
| - name: DATABASE_HOST | ||
| value: {{ include "threatsea.databaseHost" . | quote }} | ||
| - name: DATABASE_PORT |
There was a problem hiding this comment.
The Port is never read in the application code
| imagePullPolicy: {{ .Values.image.pullPolicy }} | ||
| ports: | ||
| - name: http | ||
| containerPort: {{ .Values.service.containerPort }} |
There was a problem hiding this comment.
The containerPort is configurable here, but in the application it's hardcoded to 8000, which will break if changed here
| gatewayName: "" | ||
| gatewayNamespace: "" | ||
| hostname: threatsea.example.com | ||
| tlsSecretName: "" |
There was a problem hiding this comment.
the tlsSecretName is never used in a template
2 participants
Adds a helm chart for easier ThreatSea deployments in kubernetes clusters