Scheduled Install Reminder/Relaunch Timing#372
Open
jtwillbanks wants to merge 1 commit intoMacjutsu:mainfrom
Open
Scheduled Install Reminder/Relaunch Timing#372jtwillbanks wants to merge 1 commit intoMacjutsu:mainfrom
jtwillbanks wants to merge 1 commit intoMacjutsu:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing fix for scheduled install reminder deferral when the window has passed.
Updates the set-scheduled_install_deferral() to calculate deferral_timer_minutes when a configured scheduled install reminder is greater than the remaining time.
This changes the script when the scheduled reminder has passed to set deferral_timer_minutes to the remaining minutes until workflow_scheduled_install and enforces the 2 minute minimum for the default scheduled-install deferral path.
Previously this only marked the reminder as passed and did not assign a new interval which would prevent the workflow from relaunching on the scheduled timeline.