Fixed edgecase on mac, download chromedriver = 404#571
Open
wafwoof wants to merge 2 commits into
Open
Conversation
|
I've got the same issue. Any help please? |
Author
|
I tested on my Windows machine and same problem, original theory is wrong but removing those 2 lines entirely seems like a good idea. |
|
on ubuntu 22.10 works and my machine work not fine but works, |
|
I have same problem. Anyone have any idea to resolve? |
Thanks for reply, but i put this Chrome Drive in extension Directory? Or on main Directory? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running youtube_viewer.py, my computer (MacOS 10.15.7) gave 404 errors from attempting to download the chrome driver. When debugging download_driver.py the colors import gave me trouble and that's why there's a try/catch block. gitignore file also wouldn't work with macs.
Thank you for your time.