Add validation to MultiRecord.wrsamp for segment cohesion
#559
+31
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #557, we should add segment validation when writing multi-segment records. This PR adds pre-write validation to
MultiRecord.wrsamp()by activating the previously unused_check_segment_cohesion()method, which is now called before any files are written.The validation includes checks for basic segment cohesion (matching
n_seg, sampling frequencies, and segment lengths) as well as new validation for expanded signals. For segments withe_d_signalore_p_signal, the method now verifies thatsamps_per_frameis properly set for all channels and that expanded signal lengths match expected values (samps_per_frame[ch] * sig_len). This provides clear, descriptive error messages when segments are misconfigured, preventing invalid multi-segment records from being written.