Making IdealGasThermo compatible with Forward Differentiation#10
Open
ngomezve wants to merge 27 commits intoMIT-LAE:mainfrom
Open
Making IdealGasThermo compatible with Forward Differentiation#10ngomezve wants to merge 27 commits intoMIT-LAE:mainfrom
ngomezve wants to merge 27 commits intoMIT-LAE:mainfrom
Conversation
changed x0
Delete benchmarks.jl
Contributor
Author
|
This addresses issue #10 |
deleting .json file removed rel tolerance in h
27897e9 to
41c8322
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10 +/- ##
==========================================
- Coverage 81.54% 81.52% -0.02%
==========================================
Files 11 13 +2
Lines 791 812 +21
==========================================
+ Hits 645 662 +17
- Misses 146 150 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
added automatic
689d15c to
b313848
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces parametric typing for the
Gas1DandGasobjects. In the current version, parameters inside these objects are typed asFloat64,and so are the inputs to most functions. By relaxing the typing, the package can be compatible withDualtypes, which are used by forward-mode automatic differentiation packages such asForwardDiff.jl.The PR introduces a new way to instantiate
Gasobjects viaGas(T,P), with the appropriate typing for the gas parameters being inferred from the inputs.Tests on automatic differentiation are also included, comparing against finite differences.