Open
Conversation
Contributor
ljyo2o9
commented
Jun 22, 2024
ljyo2o9
commented
- 기능 명세를 보니 userId가 필요한 것을 꺠달아 이를 수정하였습니다.
ori0o0p
reviewed
Jul 5, 2024
Collaborator
There was a problem hiding this comment.
service 로직에서 직접 SecurityContextHolder에 접근하는 건 살짝 안 좋은 설계 같아요.
SecurityContextHolder에 접근하는 클래스를 따로 나누면 좋을 것 같네요
ori0o0p
approved these changes
Jul 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.