fix(release): install examples dep group in release workflow#49
Merged
Conversation
The release workflow's ``Sync deps`` step ran ``uv sync --frozen --all-extras`` without ``--group examples``, so ``openai`` was missing from the venv and the four ``tests/test_examples_smoke.py`` cases failed at module-load time with ``ModuleNotFoundError``. ``ci.yml`` has been doing the right thing since #43; this brings ``release.yml`` in line. Surfaced when the v0.6.0 tag fired the workflow for the first time since #43 landed. The drift sat dormant because release.yml only runs on tag pushes.
There was a problem hiding this comment.
Pull request overview
This PR fixes the release workflow dependency sync so release-tag runs install the same example dependency group used by CI, allowing example smoke tests to import openai.
Changes:
- Adds
--group examplesto the release workflow’s test dependency sync step. - Documents why the examples group is needed during release tests.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The release workflow's `Sync deps` step ran `uv sync --frozen --all-extras` without `--group examples`, so `openai` was missing from the venv and the four `tests/test_examples_smoke.py` cases failed at module-load time with `ModuleNotFoundError`. `ci.yml` has been doing the right thing since #43; this brings `release.yml` in line.
The drift sat dormant because `release.yml` only runs on tag pushes — and no tag had fired between #43 landing and v0.6.0.
What's changed
`.github/workflows/release.yml`'s `Sync deps` step:
```diff
```
Next step
After this merges, delete + re-push the `v0.6.0` tag pointing at the new `main` HEAD so the release workflow re-runs against the fixed config. No PyPI upload happened on the failed run (build failed at the `test` step well before the `publish-pypi` environment approval), so retagging is safe.
Test plan