Skip to content

Set the correct scheme to transform the img tag#214

Open
blauerberg wants to merge 1 commit intoLullabot:mainfrom
blauerberg:correct-request-scheme-for-img
Open

Set the correct scheme to transform the img tag#214
blauerberg wants to merge 1 commit intoLullabot:mainfrom
blauerberg:correct-request-scheme-for-img

Conversation

@blauerberg
Copy link

fix #213

@SGudbrandsson
Copy link
Contributor

@blauerberg looks good.
Can you create a test for this as well?

@blauerberg
Copy link
Author

hmm, this problem will occured only below condition:

  • img tag that has relative path, and does'nt have 'width', 'height' attribute

In this case, it will access the image with "http" scheme to get 'width', 'height' of image even if original access is https.

But upload.wikimedia.org seems to redirect http to https.
Maybe we need the some URI that just accept only 'https' for test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Request scheme will never be HTTPS

2 participants