Update Dependencies and Remove Tests #997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CryZe
added
enhancement
CryZe
force-pushed
the
update-deps-2025-02-11
branch
2 times, most recently
from
36d44c4 to
c15e4da
Compare
The tests do not work anymore. They have always been flaky and added a lot of dependencies, that made it harder to maintain them. Additionally, the rendering is now handled by `livesplit-core`, which has all the same tests for the rendering, so it also makes little sense to have the same rendering tests again in this repository. All other dependencies that are currently updatable have been updated, except: 1. I'm not sure if you need Tauri 2 for the CLI version 2. 2. The `css-loader` causes problems with the way we import variables from the SASS files. 3. React 19 does not seem to just work, we get a bunch of TypeScript issues. 4. `commonmark` is stuck as usual until we replace it entirely. 5. `eslint` changed completely it seems, we probably need to set it up completely from scratch.
CryZe
force-pushed
the
update-deps-2025-02-11
branch
from
c15e4da to
9f9e632
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests do not work anymore. They have always been flaky and added a lot of dependencies, that made it harder to maintain them. Additionally, the rendering is now handled by
livesplit-core, which has all the same tests for the rendering, so it also makes little sense to have the same rendering tests again in this repository. All other dependencies that are currently updatable have been updated, except:css-loadercauses problems with the way we import variables from the SASS files.commonmarkis stuck as usual until we replace it entirely.eslintchanged completely it seems, we probably need to set it up completely from scratch.