Fixes line series gaps by beto-rodriguez · Pull Request #2113 · Live-Charts/LiveCharts2

beto-rodriguez · 2026-03-07T15:33:09Z

github-actions · 2026-03-07T15:33:19Z

Thanks for your contribution! 🤗 (1 / 4)

The build and test process is starting. This may take a while.
You can find more details below as the process continues or at the actions tab.

Packing complete! 📦 (2 / 4)

You can download the NuGet packages for this build here.
The packages will be available for 30 days, you can either use them directly, or wait for this PR to be merged to have them published to NuGet.org.

Running tests 🧪 (3 / 4)

Tests are running now, you can monitor their progress below or at the actions tab.

Test Results Summary (Failure) ❌ (4 / 4)

Copilot

Pull request overview

Adds a regression snapshot test to cover line series behavior when values contain gaps (null) while the bound collection is mutated (add + remove), targeting crashes reported in #1996 and #2083.

Changes:

Add LineSeriesTests.Gaps() snapshot test using an ObservableCollection<int?> with null insertions and removals.
Add the corresponding baseline snapshot image for the new test.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File	Description
tests/SnapshotTests/LineSeriesTests.cs	Adds a new snapshot test that mutates a nullable-values collection to exercise “gaps” scenarios.
tests/SnapshotTests/Snapshots/LineSeriesTests_Gaps.png	Adds the expected snapshot output for the new `Gaps` test.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-07T15:35:58Z

tests/SnapshotTests/LineSeriesTests.cs

+        _ = chart.GetImage();
+
+        var count = 0;
+        int?[] toAdd = [null, 1];
+
+        void Push()
+        {
+            points.Add(toAdd[count++ % toAdd.Length]);
+            points.RemoveAt(0);
+
+            _ = chart.GetImage();
+        }


SKCartesianChart.GetImage() returns an SKImage that holds unmanaged resources and should be disposed. These calls discard the returned image without disposing it, which can leak native memory during the test run. Consider disposing the returned image (or switching to SaveImage, which already disposes internally) for the warm-up render and for each Push() render.

github-actions · 2026-03-07T15:39:09Z

Thanks for your contribution! 🤗 (1 / 4)

The build and test process is starting. This may take a while.
You can find more details below as the process continues or at the actions tab.

Packing complete! 📦 (2 / 4)

You can download the NuGet packages for this build here.
The packages will be available for 30 days, you can either use them directly, or wait for this PR to be merged to have them published to NuGet.org.

Running tests 🧪 (3 / 4)

Tests are running now, you can monitor their progress below or at the actions tab.

Test Results Summary (Failure) ❌ (4 / 4)

github-actions · 2026-03-16T19:36:06Z

Thanks for your contribution! 🤗 (1 / 4)

The build and test process is starting. This may take a while.
You can find more details below as the process continues or at the actions tab.

Packing complete! 📦 (2 / 4)

You can download the NuGet packages for this build here.
The packages will be available for 30 days, you can either use them directly, or wait for this PR to be merged to have them published to NuGet.org.

Running tests 🧪 (3 / 4)

Tests are running now, you can monitor their progress below or at the actions tab.

Test Results Summary (Passed) ✅ (4 / 4)

Copilot

Pull request overview

Copilot reviewed 2 out of 12 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

src/LiveChartsCore/Measure/VectorManager.cs

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

github-actions · 2026-03-16T20:16:59Z

Thanks for your contribution! 🤗 (1 / 4)

The build and test process is starting. This may take a while.
You can find more details below as the process continues or at the actions tab.

Packing complete! 📦 (2 / 4)

You can download the NuGet packages for this build here.
The packages will be available for 30 days, you can either use them directly, or wait for this PR to be merged to have them published to NuGet.org.

Running tests 🧪 (3 / 4)

Tests are running now, you can monitor their progress below or at the actions tab.

Test Results Summary (Failure) ❌ (4 / 4)

Copilot

Pull request overview

Copilot reviewed 2 out of 12 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

src/LiveChartsCore/Measure/VectorManager.cs

@@ -35,6 +33,13 @@ public void AddConsecutiveSegment(Segment segment, bool followsPrevious)
        LinkedListNode<Segment>? replaceCandidate = null;
        List<LinkedListNode<Segment>>? deleteCandidates = null;



add test for #1996 and #2083

67c2857

Copilot AI review requested due to automatic review settings March 7, 2026 15:33

beto-rodriguez changed the title ~~add test for #1996 and #2083~~ Fixes line series gaps Mar 7, 2026

Copilot started reviewing on behalf of beto-rodriguez March 7, 2026 15:33 View session

beto-rodriguez marked this pull request as draft March 7, 2026 15:33

Copilot AI reviewed Mar 7, 2026

View reviewed changes

add vector operqations tests

e40b519

fixes #1996

4566f97

beto-rodriguez marked this pull request as ready for review March 16, 2026 20:11

Copilot AI review requested due to automatic review settings March 16, 2026 20:11

Copilot started reviewing on behalf of beto-rodriguez March 16, 2026 20:11 View session

Copilot AI reviewed Mar 16, 2026

View reviewed changes

src/LiveChartsCore/Measure/VectorManager.cs Show resolved Hide resolved

Potential fix for pull request finding

fea002e

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings March 16, 2026 20:16

Copilot started reviewing on behalf of beto-rodriguez March 16, 2026 20:17 View session

Copilot AI reviewed Mar 16, 2026

View reviewed changes

src/LiveChartsCore/Measure/VectorManager.cs

Comment on lines 23 to 35

@@ -35,6 +33,13 @@ public void AddConsecutiveSegment(Segment segment, bool followsPrevious)

LinkedListNode<Segment>? replaceCandidate = null;

List<LinkedListNode<Segment>>? deleteCandidates = null;

beto-rodriguez merged commit 9846312 into dev Mar 16, 2026
41 of 42 checks passed

beto-rodriguez deleted the vector-fixes branch March 18, 2026 13:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes line series gaps#2113

Fixes line series gaps#2113
beto-rodriguez merged 4 commits intodevfrom
vector-fixes

beto-rodriguez commented Mar 7, 2026

Uh oh!

github-actions bot commented Mar 7, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 7, 2026

Uh oh!

github-actions bot commented Mar 7, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 16, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

github-actions bot commented Mar 16, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		@@ -35,6 +33,13 @@ public void AddConsecutiveSegment(Segment segment, bool followsPrevious)
		LinkedListNode<Segment>? replaceCandidate = null;
		List<LinkedListNode<Segment>>? deleteCandidates = null;

Conversation

beto-rodriguez commented Mar 7, 2026

Uh oh!

github-actions bot commented Mar 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Thanks for your contribution! 🤗 (1 / 4)

Packing complete! 📦 (2 / 4)

Running tests 🧪 (3 / 4)

Test Results Summary (Failure) ❌ (4 / 4)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 7, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Thanks for your contribution! 🤗 (1 / 4)

Packing complete! 📦 (2 / 4)

Running tests 🧪 (3 / 4)

Test Results Summary (Failure) ❌ (4 / 4)

Uh oh!

github-actions bot commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Thanks for your contribution! 🤗 (1 / 4)

Packing complete! 📦 (2 / 4)

Running tests 🧪 (3 / 4)

Test Results Summary (Passed) ✅ (4 / 4)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

github-actions bot commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Thanks for your contribution! 🤗 (1 / 4)

Packing complete! 📦 (2 / 4)

Running tests 🧪 (3 / 4)

Test Results Summary (Failure) ❌ (4 / 4)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions bot commented Mar 7, 2026 •

edited

Loading

github-actions bot commented Mar 7, 2026 •

edited

Loading

github-actions bot commented Mar 16, 2026 •

edited

Loading

github-actions bot commented Mar 16, 2026 •

edited

Loading