fix: Import OrderedDict in encoder.py#22
Merged
haerski merged 2 commits intoLiquid4All:mainfrom Apr 1, 2026
Merged
Conversation
ArthurBook
approved these changes
Mar 10, 2026
Contributor
|
LGTM. @haerski what do you think? |
Collaborator
|
Maybe the correct thing to do here is to just remove the offending methods. Even with the import, the methods are still broken, because we don't import any of the other types like They are remnants from NeMO that are not used in this repo, so it should be safe |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #23