changes done by jc-efactory: #72 updated#74
Conversation
capacitor integrated, a 10mm SMD electrolitic footprint to test fix for issue LibreSolar#68, update to Kicad V9, rerouting, like the 3V3 plane was removed, now a GND layer as well and had to change a couple of capacitor to be able to fit the changes without any major redesign.
|
Heads up: once this PR is rebased on the updated main (with the KiBot v9 action from #75), the checks workflow will fail with two types of issues on the USB-C connector J3: 3 ERC errors — unconnected pins:
7 DRC errors — hole clearance violations on NPTH pads:
I reproduced this in a separate CI run. These might be pre-existing issues that KiCad v9 now reports more strictly. Two options:
# ERC: unconnected USB-C pins on J3
- filter: "Ignore unconnected USB-C pins on J3"
error: 'pin_not_connected'
regex: "Pin not connected"
# DRC: hole clearance on J3 NPTH pads
- filter: "Ignore hole clearance violations on USB-C connector J3"
error: 'hole_clearance'
regex: "Hole clearance violation.*"Note that these filters are fairly broad — ideally they'd be scoped to J3 only, but KiBot's filter regex only matches the error description, not the component reference. |
…clearances to 0.1910 mm
thanks @pasrom for heads up. I have updated as proposed. I believe they have been different in the previous version by Martin. Might have been introduce by standard setups on Joao's machine. @martinjaeger I will update the PR |
|
@martinjaeger should be ready for review now |
martinjaeger
left a comment
There was a problem hiding this comment.
The changes look good. Thanks a lot @josch-a and @jc-efactory.
We just need to update the version number of the PCB. I will merge and then do that in main.
capacitor integrated, a 10mm SMD electrolitic footprint to test fix for issue #68, update to Kicad V9, rerouting, like the 3V3 plane was removed, now a GND layer as well and had to change a couple of capacitor to be able to fit the changes without any major redesign.
deleted .history folder