Skip to content

[D]DLS-535-feat(ui-react): add MediaCard component#575

Open
zel-kass wants to merge 10 commits intomainfrom
DLS-535-feat/media-card-react
Open

[D]DLS-535-feat(ui-react): add MediaCard component#575
zel-kass wants to merge 10 commits intomainfrom
DLS-535-feat/media-card-react

Conversation

@zel-kass
Copy link
Collaborator

Overview

Introduce MediaCard component, compound pattern. Comes with its tests, docs, and figma code connect.

PS: introduced a new 'common' category to our i18n files to avoid duplication of keys such as 'Close'. Team might want to streamline this in the concerned components (such as Banner)

@zel-kass zel-kass requested a review from a team as a code owner March 18, 2026 10:39
@vercel
Copy link

vercel bot commented Mar 18, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
ldls Ready Ready Preview, Comment Mar 19, 2026 3:27pm
ldls-react-native Ready Ready Preview, Comment Mar 19, 2026 3:27pm

Request Review

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Introduces a new MediaCard component to @ledgerhq/lumen-ui-react, including its compound MediaCardTitle, with accompanying Storybook docs (stories + MDX), unit tests, Figma Code Connect wiring, and i18n additions for the close button accessible label.

Changes:

  • Added MediaCard / MediaCardTitle implementation and public exports.
  • Added Storybook stories + MDX documentation and Figma Code Connect integration.
  • Added unit tests and new common.closeAriaLabel translations across locales.

Reviewed changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
libs/ui-react/src/lib/Components/MediaCard/types.ts Defines public prop types for MediaCard / MediaCardTitle.
libs/ui-react/src/lib/Components/MediaCard/MediaCard.tsx Implements MediaCard UI, overlays, and close interaction.
libs/ui-react/src/lib/Components/MediaCard/MediaCard.test.tsx Adds unit tests for rendering, click/close behavior, image load/error, ref.
libs/ui-react/src/lib/Components/MediaCard/MediaCard.stories.tsx Adds Storybook stories for base, layout, and composition examples.
libs/ui-react/src/lib/Components/MediaCard/MediaCard.mdx Adds Storybook docs page content (overview + implementation tabs).
libs/ui-react/src/lib/Components/MediaCard/MediaCard.figma.tsx Adds Figma Code Connect mapping and example usage.
libs/ui-react/src/lib/Components/MediaCard/index.ts Exposes MediaCard module exports.
libs/ui-react/src/lib/Components/index.ts Re-exports MediaCard from the Components barrel.
libs/ui-react/src/i18n/locales/en.json Adds common.closeAriaLabel.
libs/ui-react/src/i18n/locales/es.json Adds common.closeAriaLabel.
libs/ui-react/src/i18n/locales/fr.json Adds common.closeAriaLabel.
libs/ui-react/src/i18n/locales/de.json Adds common.closeAriaLabel.
libs/ui-react/src/i18n/locales/ja.json Adds common.closeAriaLabel.
libs/ui-react/src/i18n/locales/ko.json Adds common.closeAriaLabel.
libs/ui-react/src/i18n/locales/pt.json Adds common.closeAriaLabel.
libs/ui-react/src/i18n/locales/ru.json Adds common.closeAriaLabel.
libs/ui-react/src/i18n/locales/th.json Adds common.closeAriaLabel.
libs/ui-react/src/i18n/locales/tr.json Adds common.closeAriaLabel.
libs/ui-react/src/i18n/locales/zh.json Adds common.closeAriaLabel.
.nx/version-plans/version-plan-1773849812308.md Declares a patch version plan for the new component.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

zel-kass and others added 7 commits March 19, 2026 16:24
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
… appearance variants and improved accessibility
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants