[D]DLS-535-feat(ui-react): add MediaCard component#575
Open
[D]DLS-535-feat(ui-react): add MediaCard component#575
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dda55ff to
cde6219
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Introduces a new MediaCard component to @ledgerhq/lumen-ui-react, including its compound MediaCardTitle, with accompanying Storybook docs (stories + MDX), unit tests, Figma Code Connect wiring, and i18n additions for the close button accessible label.
Changes:
- Added
MediaCard/MediaCardTitleimplementation and public exports. - Added Storybook stories + MDX documentation and Figma Code Connect integration.
- Added unit tests and new
common.closeAriaLabeltranslations across locales.
Reviewed changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| libs/ui-react/src/lib/Components/MediaCard/types.ts | Defines public prop types for MediaCard / MediaCardTitle. |
| libs/ui-react/src/lib/Components/MediaCard/MediaCard.tsx | Implements MediaCard UI, overlays, and close interaction. |
| libs/ui-react/src/lib/Components/MediaCard/MediaCard.test.tsx | Adds unit tests for rendering, click/close behavior, image load/error, ref. |
| libs/ui-react/src/lib/Components/MediaCard/MediaCard.stories.tsx | Adds Storybook stories for base, layout, and composition examples. |
| libs/ui-react/src/lib/Components/MediaCard/MediaCard.mdx | Adds Storybook docs page content (overview + implementation tabs). |
| libs/ui-react/src/lib/Components/MediaCard/MediaCard.figma.tsx | Adds Figma Code Connect mapping and example usage. |
| libs/ui-react/src/lib/Components/MediaCard/index.ts | Exposes MediaCard module exports. |
| libs/ui-react/src/lib/Components/index.ts | Re-exports MediaCard from the Components barrel. |
| libs/ui-react/src/i18n/locales/en.json | Adds common.closeAriaLabel. |
| libs/ui-react/src/i18n/locales/es.json | Adds common.closeAriaLabel. |
| libs/ui-react/src/i18n/locales/fr.json | Adds common.closeAriaLabel. |
| libs/ui-react/src/i18n/locales/de.json | Adds common.closeAriaLabel. |
| libs/ui-react/src/i18n/locales/ja.json | Adds common.closeAriaLabel. |
| libs/ui-react/src/i18n/locales/ko.json | Adds common.closeAriaLabel. |
| libs/ui-react/src/i18n/locales/pt.json | Adds common.closeAriaLabel. |
| libs/ui-react/src/i18n/locales/ru.json | Adds common.closeAriaLabel. |
| libs/ui-react/src/i18n/locales/th.json | Adds common.closeAriaLabel. |
| libs/ui-react/src/i18n/locales/tr.json | Adds common.closeAriaLabel. |
| libs/ui-react/src/i18n/locales/zh.json | Adds common.closeAriaLabel. |
| .nx/version-plans/version-plan-1773849812308.md | Declares a patch version plan for the new component. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gamegee
reviewed
Mar 19, 2026
gamegee
reviewed
Mar 19, 2026
gamegee
reviewed
Mar 19, 2026
gamegee
reviewed
Mar 19, 2026
gamegee
reviewed
Mar 19, 2026
gamegee
reviewed
Mar 19, 2026
…tionalization support
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
… appearance variants and improved accessibility
… instead of opacity
bcb064b to
c8c6376
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Introduce MediaCard component, compound pattern. Comes with its tests, docs, and figma code connect.
PS: introduced a new 'common' category to our i18n files to avoid duplication of keys such as 'Close'. Team might want to streamline this in the concerned components (such as Banner)