Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rainbow currently requires to explicitly call
setup()method to setup Unicorn-Engine hooks.Because of current design, it is impossible to cleanly change hooking configuration between two emulator run.
This patch proposes to keep track of all engine hooks registered, and to remove/update them accordingly to chosen configuration. For example it is possible to start emulation, update
print_config, then start emulation again with updated configuration.Because the hooking setup function can now be called multiple times without creating duplicated hooks, I propose to remove the explicit call to the
setup()method, making Rainbow a bit easier to use.