Prevent address generation on startup#82
Merged
Ash-L2L merged 3 commits intoJun 11, 2026
Conversation
Contributor
Ash-L2L
requested changes
May 29, 2026
| Ok(address) | ||
| } | ||
|
|
||
| pub fn get_last_address(&self) -> Result<Option<Address>, Error> { |
Collaborator
There was a problem hiding this comment.
I think a better naming convention here would be
/// Gets the latest generated address
pub fn try_get_last_address(&self) -> Result<Option<Address>, Error> {...}
/// Gets the latest generated address, or generates a new one if no addresses have already been generated
pub fn get_or_generate_last_address -> Result<Address, Error> {...}
ekulkisnek
commented
May 31, 2026
Ash-L2L
force-pushed
the
fix-address-generation-startup
branch
2 times, most recently
from
60cda9e to
838b931
Compare
Avoid generating and writing a new wallet address to LMDB every time the GUI application starts up, which could lead to performance degradation. Instead, reuse the last generated address on initialization, and only generate a new address on user demand (via explicit 'generate' button).
Ash-L2L
force-pushed
the
fix-address-generation-startup
branch
from
838b931 to
128f566
Compare
Ash-L2L
approved these changes
Jun 11, 2026
Ash-L2L
force-pushed
the
fix-address-generation-startup
branch
from
892b9c8 to
b00e10d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves the issue where the Thunder GUI window size was too small on startup and caused layout squishing (vertical letters) in the Mempool Explorer and Transaction Builder tabs.
Changes Made
eframe::NativeOptionsinapp/main.rsto set the default viewport inner size to1280x720pixels.SidePanelcontainers insideScrollAreawithui.horizontalandui.verticalcolumns using fixed widths. This resolves layout breaking and enables correct horizontal scrolling behavior. Also updated the spent UTXOs grid ID to"spent_utxos"to prevent ID collisions.ScrollAreaand replaced nestedSidePanels withui.horizontalandui.verticalcolumns. Renamed the outputs grid from"inputs"to"outputs"to fix a duplicate ID warning.cargo fmt.Verification
cargo check.cargo test.This pull request was made by Antigravity Gemini 3.5 Flash High.