fix(security): bump jackson-databind to 2.18.8 - #160
Open
alexgomezlf wants to merge 18 commits into
Open
Conversation
…54512 and CVE-2026-54513 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…tion can post check runs Default GITHUB_TOKEN permissions are read-only, so EnricoMi/publish-unit-test-result-action was failing with 403 Resource not accessible by integration on every PR. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…R comment checks:write alone got the check runs created, but the action's default comment_mode also posts/updates a PR comment, which needs pull-requests:write. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
Contributor
…lder Access denied errors trace back to the service principal not having access to whatever repo DEV_CA_PUBLIC_USE_REPOSITORY_ID_2 points to (confirmed via RepositoriesClientTest.listRepositoriesWorks: listRepositories() succeeds but that repo ID isn't in the returned list). Trying REPOSITORY_ID_1 (used by the dotnet/JS clients) with a hardcoded folder ID to see what actually fails now that auth itself isn't the blocker. Not a real fix - just a diagnostic. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
bzajzon-laserfiche
requested changes
Jul 15, 2026
bzajzon-laserfiche
left a comment
bzajzon-laserfiche
left a comment
There was a problem hiding this comment.
Jackson bump itself looks good (same as lf-api-client-core-java #86).
Requesting changes for one blocker:
- Remove the
[RETRY-DEBUG]System.out.printlncalls inApiClientUtils.sendRequestWithRetry— debug scaffolding that would ship in the published client, printing request URLs/statuses to consumers' stdout.
Minor:
- PR body only mentions the jackson bump — please also describe the test/CI changes (audit-reason handling, fail-fast task polling, REPOSITORY_ID secret swap), or split them out.
- Confirm a tracking issue exists for the v1 branch's same vulnerable pin.
Debug scaffolding left in sendRequestWithRetry would have shipped in the published client, printing request URLs/statuses to consumers' stdout.
Contributor
Author
|
Thanks for the review!
Commit 690efa9 has the fix pushed. |
bzajzon-laserfiche
approved these changes
Jul 15, 2026
bzajzon-laserfiche
left a comment
bzajzon-laserfiche
left a comment
There was a problem hiding this comment.
All feedback addressed — thanks:
[RETRY-DEBUG]printlns removed; the diff no longer touches production source at all (test + CI + pom/CHANGELOG only).- PR body now documents the test/CI changes and their rationale; fine to keep them bundled given they're test-only and needed for a green suite.
One follow-up: please do file the v1 tracking issue mentioned in the description so the same vulnerable pin there doesn't get lost.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the shared
jackson-versionproperty from 2.18.2 to 2.18.8 to remediate two Veracode-flagged CVEs in jackson-databind:Both are fixed upstream in 2.18.8.
Note: the v1 branch has the same vulnerable pin but is out of scope here since the flagged Veracode build corresponds to v2. A tracking issue for the v1 fix will be filed separately.
Fixes #679086
Fixes #679087
Test / CI changes
Alongside the jackson bump, this PR also includes integration-test and workflow fixes needed to get the suite green against the current dev/CA repository:
BaseTest,EntriesClientTest,TasksClientTest): the dev/CA repo now enforces an audit reason onDeleteEntry(errorCode 216), unlike the old dedicated test repo. AddedgetDeleteAuditReasonId()/newDeleteEntryRequest()helpers that resolve and cache the delete audit reason (mirroring the existing export audit-reason lookup) and swapped all barenew StartDeleteEntryRequest()call sites over to it.BaseTest.waitUntilTaskEnds): previously a task ending in a non-IN_PROGRESS, non-success state would fall through as if it succeeded. Now a terminal status other thanCOMPLETEDthrows immediately with the task'sProblemDetails(title/detail/status/errorCode/errorSource) surfaced via a newformatErrorshelper, instead of masking the failure or requiring a timeout to notice.ExportDocumentApiTest,ImportUploadedPartsApiTest): wrappedexportEntry/multipart-upload/task-list calls so anApiException's status code, headers, and problem details show up in the surefire report — we don't have access to the raw CI job log to see the actual HTTP response otherwise.REPOSITORY_IDsecret swap (.github/workflows/main.yml): integration tests now useDEV_CA_PUBLIC_USE_REPOSITORY_ID_1instead of..._2, and the workflow grantschecks: write/pull-requests: writeso the test-results action can publish/update its PR comment.Happy to split the test/CI changes into a separate PR if preferred — flagging here since they're bundled with the security fix in this diff.