Conversation
szeli1
left a comment
There was a problem hiding this comment.
My concern with this PR is that it looks like to me that other "ctrl + alt" mouse shortcuts may not work because of the event filter. I did not test this PR.
Here is some code that may be effected:
AutomationEditor:
}
else if( we->modifiers() & Qt::ControlModifier && we->modifiers() & Qt::AltModifier )
{ClipView:
bool ClipView::unquantizedModHeld( QMouseEvent * me )
{
return me->modifiers() & Qt::ControlModifier || me->modifiers() & Qt::AltModifier;
}PianoRoll:
void PianoRoll::dragNotes(int x, int y, bool alt, bool shift, bool ctrl)Co-authored-by: szeli1 <143485814+szeli1@users.noreply.github.com>
|
Changed the keybinding to Also a note to self: adding the keybinding handling on the event filter is sadly necessary, as when it is pressed I have to prevent it from being forwarded to other elements. I tried implementing it with key{Press,Release}Event and it was a mess. |
If I remember correctly, there are other options like implementing it in |
|
|
||
| #include <QApplication> | ||
| #include <QCloseEvent> | ||
| #include <QDebug> // TODO: remove (along with other qDebug instances here) |
There was a problem hiding this comment.
| #include <QDebug> // TODO: remove (along with other qDebug instances here) |
This PR adds the ability to pan through the workspace without having to click on the background, primarily through a new keybinding to start panning (which I am calling "universal panning"), but also through the returnal of scrollbars.
For the panning keybinding, the trigger I have set up at the moment is the key combo
Ctrl+Alt+ClickAlt+S+Click, which might not be ideal, but it was the most unique modifier combination I could think of.2026-01-26.panning_scroll_demo.v2.mp4
Progress:
Ctrl+Alt->Alt+S8d333a48b)Feedback is very welcome on this PR. When testing, keep an eye out for whether the scroll bars are working properly and whether panning feels natural, or if it's error prone.