Make automation nodes return outValue to handle discrete jumps without delay.#8104
Open
Jan125 wants to merge 16 commits intoLMMS:masterfrom
Open
Make automation nodes return outValue to handle discrete jumps without delay.#8104Jan125 wants to merge 16 commits intoLMMS:masterfrom
Jan125 wants to merge 16 commits intoLMMS:masterfrom
Conversation
Note slides had a 1 tick delay which desynchronized them. This may be a breaking change.
Contributor
Author
|
I've not noticed any regressions so far. |
Contributor
Author
|
I have just found an issue where for discrete automation only, it triggers 1 tick too early. |
Contributor
Author
|
It seems to happen for all interactions except outvalues. |
Jan125
force-pushed
the
noteslidedelayfix
branch
from
66e0cf5 to
fcf975b
Compare
Contributor
Author
|
valueAt now returns the outValue for a node instead on an inValue by default. |
Jan125
changed the title
messmerd
reviewed
Nov 2, 2025
Replace bool = 0 wit bool = false. - "Oopsie woopsie". Co-authored-by: Dalton Messmer <messmer.dalton@gmail.com>
Co-Authored-By: Dalton Messmer <messmer.dalton@gmail.com>
messmerd
reviewed
Nov 6, 2025
Co-authored-by: Dalton Messmer <messmer.dalton@gmail.com>
Co-authored-by: Dalton Messmer <messmer.dalton@gmail.com>
Co-authored-by: Dalton Messmer <messmer.dalton@gmail.com>
messmerd
approved these changes
Jan 4, 2026
Member
messmerd
left a comment
messmerd
left a comment
There was a problem hiding this comment.
Sorry for the delay. The code changes look good to me - just needs some testing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note slides had a 1 tick delay which desynchronized them.
This may be a breaking change.
Compare these two audio files:
commbuoy_noteslide_old.mp3
commbuoy_noteslide_new.mp3