Skip to content

feat(x509): add test for standalone Authorino x509.source.expression#939

Open
averevki wants to merge 2 commits intoKuadrant:mainfrom
averevki:x509-CEL-on-authconfig
Open

feat(x509): add test for standalone Authorino x509.source.expression#939
averevki wants to merge 2 commits intoKuadrant:mainfrom
averevki:x509-CEL-on-authconfig

Conversation

@averevki
Copy link
Copy Markdown
Contributor

Summary

  • Add test for x509.source.expression field on standalone Authorino AuthConfig, verifying that explicitly specifying source.certificate via CEL produces the same result as omitting the source key
  • Rename standalone Authorino TLS test directory and files from tls/mtls to x509/gateway_validation to better reflect the x509 identity feature being tested

Verification

make testsuite/tests/singlecluster/authorino/operator/x509/                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                

Closes #938

Signed-off-by: averevki <sandyverevkin@gmail.com>
@averevki averevki self-assigned this Apr 17, 2026
@averevki averevki added Test case New test case Service Protection Issues for Service Protection tests labels Apr 17, 2026
@averevki averevki moved this to Ready For Review in Kuadrant Apr 17, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 17, 2026

Warning

Rate limit exceeded

@averevki has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 4 minutes and 59 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 4 minutes and 59 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d49d019a-ceda-47ad-9697-8ed22cd6ec3d

📥 Commits

Reviewing files that changed from the base of the PR and between c687431 and fd2e65d.

📒 Files selected for processing (13)
  • testsuite/kuadrant/policy/authorization/__init__.py
  • testsuite/kuadrant/policy/authorization/sections.py
  • testsuite/tests/singlecluster/authorino/operator/x509/README.md
  • testsuite/tests/singlecluster/authorino/operator/x509/__init__.py
  • testsuite/tests/singlecluster/authorino/operator/x509/conftest.py
  • testsuite/tests/singlecluster/authorino/operator/x509/gateway_validation/__init__.py
  • testsuite/tests/singlecluster/authorino/operator/x509/gateway_validation/conftest.py
  • testsuite/tests/singlecluster/authorino/operator/x509/gateway_validation/test_x509_attributes.py
  • testsuite/tests/singlecluster/authorino/operator/x509/gateway_validation/test_x509_cel_source.py
  • testsuite/tests/singlecluster/authorino/operator/x509/gateway_validation/test_x509_identity.py
  • testsuite/tests/singlecluster/authorino/operator/x509/gateway_validation/test_x509_trust_chain.py
  • testsuite/tests/singlecluster/authorino/operator/x509/test_webhook.py
  • testsuite/tests/singlecluster/authorino/operator/x509/test_x509.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@averevki averevki force-pushed the x509-CEL-on-authconfig branch from 408e595 to f482eda Compare April 17, 2026 13:35
@averevki averevki requested review from a team and guicassolato April 17, 2026 13:35
…field

Signed-off-by: averevki <sandyverevkin@gmail.com>
@averevki averevki force-pushed the x509-CEL-on-authconfig branch from f482eda to fd2e65d Compare April 17, 2026 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Service Protection Issues for Service Protection tests Test case New test case

Projects

Status: Ready For Review

Development

Successfully merging this pull request may close these issues.

[X.509] CEL Expression with Standalone Authorino AuthConfig

1 participant