SSA requires delete permission for controller ref#295
Merged
adam-cattermole merged 2 commits intomainfrom Feb 18, 2026
Merged
Conversation
Signed-off-by: Adam Cattermole <a.d.cattermole@gmail.com>
Member
Author
|
Tests are failing as GCS bucket access has been revoked for the envtest version for controller-runtime v0.16.. |
Signed-off-by: Adam Cattermole <a.d.cattermole@gmail.com>
Member
Author
|
Looks like there would be quite a few changes to upgrade from such an old version of controller-runtime to a newer one - for now I've pinned the version of envtest to a newer version and we can create a follow on to update controller-runtime and unpin |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #295 +/- ##
=======================================
Coverage 57.20% 57.20%
=======================================
Files 13 13
Lines 1458 1458
=======================================
Hits 834 834
Misses 529 529
Partials 95 95
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With server-side-apply the k8s API server validates the operator has permissions to delete the resource when it sets controller reference on an object. Without SSA, the operator could still set controller ref and trigger cascading deletion implicitly without the RBAC, but the SSA security model is stricter and requires explicit permission in OCP