Skip to content

SSA requires delete permission for controller ref#295

Merged
adam-cattermole merged 2 commits intomainfrom
ssa-rbac
Feb 18, 2026
Merged

SSA requires delete permission for controller ref#295
adam-cattermole merged 2 commits intomainfrom
ssa-rbac

Conversation

@adam-cattermole
Copy link
Copy Markdown
Member

@adam-cattermole adam-cattermole commented Feb 17, 2026

With server-side-apply the k8s API server validates the operator has permissions to delete the resource when it sets controller reference on an object. Without SSA, the operator could still set controller ref and trigger cascading deletion implicitly without the RBAC, but the SSA security model is stricter and requires explicit permission in OCP

Signed-off-by: Adam Cattermole <a.d.cattermole@gmail.com>
@adam-cattermole adam-cattermole self-assigned this Feb 17, 2026
@adam-cattermole adam-cattermole moved this to In Progress in Kuadrant Feb 17, 2026
@adam-cattermole
Copy link
Copy Markdown
Member Author

Tests are failing as GCS bucket access has been revoked for the envtest version for controller-runtime v0.16..

Signed-off-by: Adam Cattermole <a.d.cattermole@gmail.com>
@adam-cattermole
Copy link
Copy Markdown
Member Author

Looks like there would be quite a few changes to upgrade from such an old version of controller-runtime to a newer one - for now I've pinned the version of envtest to a newer version and we can create a follow on to update controller-runtime and unpin

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.20%. Comparing base (5a32c4c) to head (3e32377).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #295   +/-   ##
=======================================
  Coverage   57.20%   57.20%           
=======================================
  Files          13       13           
  Lines        1458     1458           
=======================================
  Hits          834      834           
  Misses        529      529           
  Partials       95       95           
Flag Coverage Δ
unit 57.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@adam-cattermole adam-cattermole marked this pull request as ready for review February 17, 2026 15:28
@adam-cattermole adam-cattermole moved this from In Progress to Ready For Review in Kuadrant Feb 17, 2026
@adam-cattermole adam-cattermole added the kind/bug Something isn't working label Feb 18, 2026
Copy link
Copy Markdown
Member

@didierofrivia didierofrivia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦭

@adam-cattermole adam-cattermole added this pull request to the merge queue Feb 18, 2026
Merged via the queue into main with commit 997a61a Feb 18, 2026
13 checks passed
@adam-cattermole adam-cattermole deleted the ssa-rbac branch February 18, 2026 09:48
@github-project-automation github-project-automation Bot moved this from Ready For Review to Done in Kuadrant Feb 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants