Fix: honor break-before and break-after on floated elements#2728
Open
danfitz36 wants to merge 1 commit intoKozea:mainfrom
Open
Fix: honor break-before and break-after on floated elements#2728danfitz36 wants to merge 1 commit intoKozea:mainfrom
danfitz36 wants to merge 1 commit intoKozea:mainfrom
Conversation
Floated elements bypassed break property handling because they are routed through _out_of_flow_layout instead of _in_flow_layout. Add forced page break detection for floats following the CSS Fragmentation spec: "User agents should also apply these properties to floated boxes whose containing block is in the normal flow of the root fragmented element." Fixes Kozea#2277 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_out_of_flow_layoutinstead of_in_flow_layoutbreak-beforeandbreak-afteron floated elementsTest plan
test_float_break_after_page— verifiesbreak-after: pageon a float forces a page breaktest_float_break_before_page— verifiesbreak-before: pageon a float forces a page breakFixes #2277