Closed
Conversation
ilya-g
requested changes
Dec 5, 2023
Author
|
Hi @ilya-g, should this be merged or rejected? |
ilya-g
requested changes
Jan 22, 2024
| Notice that, instead of the general `DateTimeUnit` and `DateTimePeriod` types, we're using their subtypes | ||
| `DateTimeUnit.DateBased` and `DatePeriod` respectively. This allows preventing the situations when | ||
| time components are being added to a date at compile time. | ||
| time components are being added to date at compile time. |
Member
There was a problem hiding this comment.
"a date" here means "an instance of LocalDate type"
| ``` | ||
|
|
||
| - In multiplatform projects, add a dependency to the commonMain source set dependencies | ||
| - In multiplatform projects, add a dependency to the `commonMain` source set of dependencies |
Member
There was a problem hiding this comment.
It's the dependencies DSL block of a source set, not a set of dependencies.
|
|
||
| The project requires JDK 8 to build classes and to run tests. | ||
| Gradle will try to find it among the installed JDKs or [provision](https://docs.gradle.org/current/userguide/toolchains.html#sec:provisioning) it automatically if it couldn't be found. | ||
| Gradle will try to find it among the installed JDKs or [provision](https://docs.gradle.org/current/userguide/toolchains.html#sec:provisioning) automatically if it can't be found. |
Member
There was a problem hiding this comment.
Better to reword as "[download] it automatically"
Collaborator
|
Closed in favor of #578 |
Author
|
Apologies for not responding earlier, I haven't received notification at the time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just fixing a few typos in the
README.md