Adding the sylph coverage model to yacht #141
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Hi @dkoslicki and team!
I created a sylph coverage model from Shaw and Yu, 2024 and added it to yacht, in a branch I named superyacht just for fun.
This is a draft that I'm still testing, so that and other caveats still apply. A few notes:
cov_calc, which calculates lambda and ani according as specified by the sylph paper.cov_calcinsideget_exclusive_hashes, given that that function provides us with the signature objects needed to make the calculations.hypothesis_recovery. There are probably good ways to integrate this, and I'll give this some more thought.cov_calcmore deeply intohypothesis_recoveryfor now. I have some ideas on what might be the best approach that we could discuss if you'd like. I thought it would be best to share this new branch while I look into this more deeply.internal_superyacht_test.pyis just a script that I have been using to test the new branch, and this can be ignored; I'll remove it once we move towards publication.AdjustStatusLambdaenum in a more idiomatic python way this week. It should be a relatively quick fix.winner_maproutine from sylph, but it's something I would like to add.I'm going to do more testing this week on additional datasets. Happy to discuss here or via email/video!