fix(analytics): return early on aborted requests to avoid retrying [MA-4715]#2913
Open
jordojordo wants to merge 1 commit intomainfrom
Open
fix(analytics): return early on aborted requests to avoid retrying [MA-4715]#2913jordojordo wants to merge 1 commit intomainfrom
jordojordo wants to merge 1 commit intomainfrom
Conversation
13422b8 to
b3e438f
Compare
Collaborator
Preview components from this PR in consuming applicationIn consuming application project install preview versions of shared packages generated by this PR: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix MA-4715
Summary
This fixes two issues that are caused by aborted requests from the
QueryDataProvidercomponent.queryErrorto be set but with no message, causing a empty state. This will fall back to a generic error message when that occurs.useRequestQueuewould still hold reference to the now dead request.In order to solve for the second issue, the request queue now returns early when a request is already aborted, and we have one retry within the QueryDataProvider to re-issue a request.
I have added a new utility to determine if a query error is actually a canceled or aborted request.