Skip to content

fix(analytics): return early on aborted requests to avoid retrying [MA-4715]#2913

Open
jordojordo wants to merge 1 commit intomainfrom
fix/ma-4715
Open

fix(analytics): return early on aborted requests to avoid retrying [MA-4715]#2913
jordojordo wants to merge 1 commit intomainfrom
fix/ma-4715

Conversation

@jordojordo
Copy link
Member

@jordojordo jordojordo commented Feb 6, 2026

Fix MA-4715

Summary

This fixes two issues that are caused by aborted requests from the QueryDataProvider component.

  1. When a request is aborted due to the component being unmounted, this would cause a queryError to be set but with no message, causing a empty state. This will fall back to a generic error message when that occurs.
  2. Aborted requests caused by unmounting the component would be cached by SWRV. This is expected, however, the useRequestQueue would still hold reference to the now dead request.

In order to solve for the second issue, the request queue now returns early when a request is already aborted, and we have one retry within the QueryDataProvider to re-issue a request.

I have added a new utility to determine if a query error is actually a canceled or aborted request.

@jordojordo jordojordo requested a review from a team as a code owner February 6, 2026 17:53
@kongponents-bot
Copy link
Collaborator

Preview components from this PR in consuming application

In consuming application project install preview versions of shared packages generated by this PR:

@kong-ui-public/analytics-chart@pr-2913
@kong-ui-public/dashboard-renderer@pr-2913

Copy link
Contributor

@adorack adorack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants