Skip to content

chore(core): remove accidental console.logs#2885

Open
johncowen wants to merge 1 commit intomainfrom
chore/console-nits
Open

chore(core): remove accidental console.logs#2885
johncowen wants to merge 1 commit intomainfrom
chore/console-nits

Conversation

@johncowen
Copy link
Collaborator

@johncowen johncowen commented Jan 28, 2026

Summary

I've been involved in some other work related to this repository and I noticed a couple of stray console.logs I get this is a total nit (sorry! 😅 ) but I'd rather do something about it than just leave it as it is.


Whilst there is some actual code here I've removed, I'm pretty sure there are no side-effects in removing an empty watch (empty once the console is removed). I also can't imagine why someone would have left these in on purpose i.e. I think this was just an accident missed in review.


I considered adding a lint rule to catch this, but I also noticed there are extensive usages of console.log in tests and sandboxes etc. which means it would be a lot of tedious work to go through and remove those, or figure out some sort of ignore approach. As these logs aren't end user facing I didn't go any further.

@kongponents-bot
Copy link
Collaborator

Preview components from this PR in consuming application

In consuming application project install preview versions of shared packages generated by this PR:

@kong-ui-public/app-layout@pr-2885
@kong-ui-public/expressions@pr-2885
@kong-ui-public/entities-routes@pr-2885
@kong-ui-public/entities-plugins@pr-2885

@kongponents-bot
Copy link
Collaborator

🔴 PR audit failed. 🔴

🔥 No test coverage detected.

This PR does not include any test coverage changes, but it modifies source code. Please add appropriate tests to cover the changes made in this PR.

If you believe this is a false positive or if there are valid reasons for not including test coverage changes, please request an exemption by adding the test-coverage-exempt label to the PR and ensure it is approved by one of those managers jillztom, nateslo, erichsend, lahabana, hangrao, ryanmoore, elen4, DaniellaFreese, mfollett, ValeryG.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants