Open
Conversation
Collaborator
Preview components from this PR in consuming applicationIn consuming application project install preview versions of shared packages generated by this PR: |
adamdehaven
approved these changes
Jan 28, 2026
Collaborator
🔴 PR audit failed. 🔴🔥 No test coverage detected.This PR does not include any test coverage changes, but it modifies source code. Please add appropriate tests to cover the changes made in this PR. If you believe this is a false positive or if there are valid reasons for not including test coverage changes, please request an exemption by adding the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I've been involved in some other work related to this repository and I noticed a couple of stray console.logs I get this is a total nit (sorry! 😅 ) but I'd rather do something about it than just leave it as it is.
Whilst there is some actual code here I've removed, I'm pretty sure there are no side-effects in removing an empty watch (empty once the console is removed). I also can't imagine why someone would have left these in on purpose i.e. I think this was just an accident missed in review.
I considered adding a lint rule to catch this, but I also noticed there are extensive usages of
console.login tests and sandboxes etc. which means it would be a lot of tedious work to go through and remove those, or figure out some sort of ignore approach. As these logs aren't end user facing I didn't go any further.