build(Examples): provide standalone build for apps#3426
build(Examples): provide standalone build for apps#3426finetjul merged 1 commit intoKitware:masterfrom
Conversation
|
@finetjul If you could try it out to confirm everything works as expected, that would be great. |
|
🙏 I successfully built those examples (built in vtk-js/dist/examples) Will those examples be served by VitePress ? If you generate both versions, maybe the fullscreen version of the examples should have no import. WDYT ? |
|
@finetjul Yes, it should be. I don't generate both versions, i generate IIFE for Applications and ES modules for everything else. The fullscreen button should display the original source code from the index.js. If you merge and i can fix provide a fix we something goes wrong |
|
@finetjul it worked! |
|
@finetjul do you know if we need the js inside the HTML for standalone apps ? |
|
yes we do |
|
🎉 This PR is included in version 34.16.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Context
#3419
Results
Provide standalone build for applications
Changes
PR and Code Checklist
npm run reformatto have correctly formatted codeTesting