Skip to content

build(Examples): provide standalone build for apps#3426

Merged
finetjul merged 1 commit intoKitware:masterfrom
daker:standalone-examples-build
Feb 25, 2026
Merged

build(Examples): provide standalone build for apps#3426
finetjul merged 1 commit intoKitware:masterfrom
daker:standalone-examples-build

Conversation

@daker
Copy link
Collaborator

@daker daker commented Feb 25, 2026

Context

#3419

Results

Provide standalone build for applications

Changes

  • Documentation and TypeScript definitions were updated to match those changes

PR and Code Checklist

  • semantic-release commit messages
  • Run npm run reformat to have correctly formatted code

Testing

  • This change adds or fixes unit tests
  • Tested environment:
    • vtk.js:
    • OS:
    • Browser:

@daker
Copy link
Collaborator Author

daker commented Feb 25, 2026

@finetjul If you could try it out to confirm everything works as expected, that would be great.

@finetjul
Copy link
Member

🙏 I successfully built those examples (built in vtk-js/dist/examples)

Will those examples be served by VitePress ? If you generate both versions, maybe the fullscreen version of the examples should have no import.

WDYT ?

@daker
Copy link
Collaborator Author

daker commented Feb 25, 2026

@finetjul Yes, it should be. I don't generate both versions, i generate IIFE for Applications and ES modules for everything else. The fullscreen button should display the original source code from the index.js. If you merge and i can fix provide a fix we something goes wrong

@finetjul finetjul added this pull request to the merge queue Feb 25, 2026
Merged via the queue into Kitware:master with commit a8167fc Feb 25, 2026
2 checks passed
@daker daker deleted the standalone-examples-build branch February 25, 2026 16:46
@daker
Copy link
Collaborator Author

daker commented Feb 25, 2026

@finetjul it worked!

@daker
Copy link
Collaborator Author

daker commented Feb 25, 2026

@finetjul do you know if we need the js inside the HTML for standalone apps ?

@jourdain
Copy link
Collaborator

yes we do

@github-actions
Copy link

🎉 This PR is included in version 34.16.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Automated label label Feb 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Automated label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants