fix(SplineWidget): fix bug where SplineWidget handles cannot be dragged after creation#3400
Merged
finetjul merged 1 commit intoKitware:masterfrom Feb 5, 2026
Merged
Conversation
…ed after creation
finetjul
approved these changes
Feb 5, 2026
Member
finetjul
left a comment
There was a problem hiding this comment.
You wouldn't need it if the widget had the focus while dragging the control point. However it seems that other widgets don't do that.
Let's merge your change but let's keep in mind that widget should probably grab focus in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
npm run example SplineWidget.Results
The handles are unresponsive; the control points cannot be dragged or moved.
Changes
Root Cause Analysis: The issue occurs because the handleMouseMove method in SplineWidget does not return macro.EVENT_ABORT when isHandleMoving is true. Even though the widget is currently in a dragging state, the mouse event continues to propagate to other subscribers. Consequently, the WidgetManager captures the event and triggers the w.deactivateAllHandles() method, which deactivates the currently selected handle and interrupts the drag operation.
Proposed Fix: To resolve this, we must return macro.EVENT_ABORT within the handleMouseMove logic whenever isHandleMoving is true. This ensures that the event is consumed by the active widget and prevented from propagating to the WidgetManager or other listeners.
PR and Code Checklist
npm run reformatto have correctly formatted codeTesting