docs(website): fix website examples#3395
Conversation
|
@jourdain Could you check this? I moved some files around to make VitePress work as expected. The examples build time should drop from ~10 min to ~25 secs. |
| @@ -11,4 +11,4 @@ If you are looking for general information on VTK pipelines, data structures, an | |||
| [![VTK Book][Book]](https://www.vtk.org/vtk-textbook/) | |||
| [Download the book in PDF for free](https://www.vtk.org/vtk-textbook/) | |||
|
|
|||
| [Book]: ./books_VTK_textbook.png | |||
There was a problem hiding this comment.
Are you sure? That was working in the current deployed version
There was a problem hiding this comment.
yes i moved the static files under public
| @@ -160,4 +160,4 @@ representations, check out the above `SVGHelpers.js`, which requires `snabbdom` | |||
| to be installed. An example usage can be found in the `vtkPolyLineWidget` | |||
| example. | |||
|
|
|||
| [WidgetsDiagram]: ./gallery/widgets_diagram.png | |||
There was a problem hiding this comment.
I guess you validated that links path should be absolute
There was a problem hiding this comment.
That’s what the documentation says when a base URL is used.
|
We just need to wait on the CI and see if that fix the current set of issues. Otherwise, the changes you've made make sense. |
|
You need to fix the ci workflow that still do a check on |
Head branch was pushed to by a user without write access
|
I think you need to fix the ci yaml as they are still pointing to old npm target. ( |
|
i think it should be good now |
|
Just forced merge after the basic check went through... Now we should monitor https://github.com/Kitware/vtk-js/actions/runs/21609596305 |
|
Looks great, thanks! I think we can gradually improve things from now. Thanks again for doing that migration. |
|
@jourdain The full build now takes 3 minutes, and it’s starting to look much better. |
|
Indeed, do you know how we can for few examples build them as standalone html (no side files)? The reason why I'm asking is that we need those standalone "apps" like in the case of trame-vtk and more specifically this issue which is linked to that line. |
2 participants
Context
Results
Changes
PR and Code Checklist
npm run reformatto have correctly formatted codeTesting