Skip to content

math_brute_force: Refactor input generation & reduce default test size#2697

Merged
neiltrevett merged 1 commit into
KhronosGroup:mainfrom
rjodinchr:math-brute-force-special-values
Jul 14, 2026
Merged

math_brute_force: Refactor input generation & reduce default test size#2697
neiltrevett merged 1 commit into
KhronosGroup:mainfrom
rjodinchr:math-brute-force-special-values

Conversation

@rjodinchr

@rjodinchr rjodinchr commented May 19, 2026

Copy link
Copy Markdown
Collaborator

This patch consolidates the hardcoded arrays of edge-case test values
from multiple individual test files into a single, shared location.

@rjodinchr rjodinchr force-pushed the math-brute-force-special-values branch 2 times, most recently from 25ff430 to 65ad379 Compare May 19, 2026 14:43
@rjodinchr rjodinchr force-pushed the math-brute-force-special-values branch from 65ad379 to cc958dc Compare May 22, 2026 09:23
@rjodinchr rjodinchr changed the title math_brute_force: Group special values to reduce code duplication math_brute_force: Refactor input generation & reduce default test size May 22, 2026
@rjodinchr rjodinchr force-pushed the math-brute-force-special-values branch 7 times, most recently from 8c6d9be to e6d7f0d Compare May 28, 2026 15:05
@rjodinchr

Copy link
Copy Markdown
Collaborator Author

Depends on #2706

@rjodinchr rjodinchr force-pushed the math-brute-force-special-values branch from e6d7f0d to ed3000d Compare May 28, 2026 15:19
@rjodinchr rjodinchr marked this pull request as draft June 11, 2026 06:48
@joselopeqti

Copy link
Copy Markdown
Collaborator

Hi @rjodinchr, would it be possible to rebase to main?

@rjodinchr rjodinchr force-pushed the math-brute-force-special-values branch from ed3000d to 7a03c05 Compare June 15, 2026 17:20
@rjodinchr

Copy link
Copy Markdown
Collaborator Author

ref #2723

This patch consolidates the hardcoded arrays of edge-case test values
from multiple individual test files into a single, shared location.
@rjodinchr rjodinchr force-pushed the math-brute-force-special-values branch from 7a03c05 to f96f5ad Compare July 3, 2026 14:41
@rjodinchr rjodinchr marked this pull request as ready for review July 3, 2026 14:41
@rjodinchr rjodinchr requested a review from ahesham-arm July 8, 2026 15:45
@ahesham-arm

Copy link
Copy Markdown
Collaborator

LGTM. Generally do we need these to be std::vector or is std::array a better fit here?

@rjodinchr

Copy link
Copy Markdown
Collaborator Author

LGTM. Generally do we need these to be std::vector or is std::array a better fit here?

Even though C++17 allows for variable initialization without specifying the size, function prototypes still require it.
This means get*SpecialValues must explicitly expose the element count, creating a maintenance burden whenever elements are added or removed, despite providing little to no performance benefit.

@ahesham-arm

Copy link
Copy Markdown
Collaborator

Makes sense, thanks for checking.

@rjodinchr

Copy link
Copy Markdown
Collaborator Author

@bashbaug @kpet, is this fine to merge right now, as this is a non-functional change with an approval?
It would allow me to push the next one for math_brute_force which will really be reducing the workload.

@neiltrevett neiltrevett merged commit 372bcd6 into KhronosGroup:main Jul 14, 2026
9 checks passed
@rjodinchr rjodinchr deleted the math-brute-force-special-values branch July 15, 2026 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants