math_brute_force: Refactor input generation & reduce default test size#2697
Merged
neiltrevett merged 1 commit intoJul 14, 2026
Merged
Conversation
25ff430 to
65ad379
Compare
65ad379 to
cc958dc
Compare
8c6d9be to
e6d7f0d
Compare
Collaborator
Author
|
Depends on #2706 |
e6d7f0d to
ed3000d
Compare
Collaborator
|
Hi @rjodinchr, would it be possible to rebase to main? |
ed3000d to
7a03c05
Compare
Collaborator
Author
|
ref #2723 |
This patch consolidates the hardcoded arrays of edge-case test values from multiple individual test files into a single, shared location.
7a03c05 to
f96f5ad
Compare
Collaborator
|
LGTM. Generally do we need these to be |
Collaborator
Author
Even though C++17 allows for variable initialization without specifying the size, function prototypes still require it. |
Collaborator
|
Makes sense, thanks for checking. |
ahesham-arm
approved these changes
Jul 10, 2026
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch consolidates the hardcoded arrays of edge-case test values
from multiple individual test files into a single, shared location.