Make key-offset shifts deterministic - #335
Draft
ezfoom wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
train_gpt.pyandtrain_gpt_medium.py.Root cause
The assignments write
k[:, 1:]while reading the overlappingk[:, :-1]view on CUDA. The copy kernel can observe values that another thread has already overwritten, so the result depends on execution order instead of representing a stable one-token shift.At the record-84 tensor shape on an H100, eight repeated runs from the same input produced a maximum element delta of
7.28125with the overlapping assignment. Cloning the RHS produced0.0repeat delta.Impact
Key-offset attention becomes deterministic and matches the shift described by the surrounding comment. This affects the long-window key-offset paths in both training scripts.
Validation
[1, 16384, 6, 128]: overlap repeat delta7.28125; cloned RHS0.0python3 -m py_compile train_gpt.py train_gpt_medium.pygit diff --check