Fix exclamation points in file names breaking the patcher#38
Open
TheShadowEevee wants to merge 3 commits intoKcrPL:masterfrom
TheShadowEevee:master
Open
Fix exclamation points in file names breaking the patcher#38TheShadowEevee wants to merge 3 commits intoKcrPL:masterfrom TheShadowEevee:master
TheShadowEevee wants to merge 3 commits intoKcrPL:masterfrom
TheShadowEevee:master
Conversation
TheShadowEevee
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Desc: Fix exclamation points in file names breaking the patcher
Fixes #28
Problem:
A fairly long standing bug where the patcher breaks with exclamation points due to having
ENABLEDELAYEDEXPANSIONset in the patcher for the file counter has been known, and I've been trying to fix it for a few hours now. I have found no other special characters that exhibit this behavior, but if another shows up it will only take one line to fix.Solution:
After some tinkering, I figured out that we are able to move the
ENABLEDELAYEDEXPANSIONsetlocal call to right before it's needed in the patcher, and before that run a few commands to remove exclamation points from the file names of anything matching*.wadin the patcher's folder.Operating Systems Edited: WINDOWS