Skip to content

Important Contributions in your repo#2

Open
viramyadav187 wants to merge 2 commits intoKasRoudra:mainfrom
viramyadav187:main
Open

Important Contributions in your repo#2
viramyadav187 wants to merge 2 commits intoKasRoudra:mainfrom
viramyadav187:main

Conversation

@viramyadav187
Copy link
Copy Markdown

Imports and Dependency Handling:
Moved pyftpdlib imports inside a function to delay the import until necessary.
Added an installation function to handle pyftpdlib dependency automatically.

Logging:
Replaced print statements with logging for better control and verbosity.

TLS/SSL Support:
Added an option to enable secure FTP using TLS/SSL. This requires a valid certificate.

Enhanced User Input Handling:
Improved the get_path and get_port functions for more robust user input validation.

General Code Optimization:
Simplified some repetitive patterns and used dictionary-based color management.

Imports and Dependency Handling:

Moved pyftpdlib imports inside a function to delay the import until necessary.
Added an installation function to handle pyftpdlib dependency automatically.
Logging:

Replaced print statements with logging for better control and verbosity.
TLS/SSL Support:

Added an option to enable secure FTP using TLS/SSL. This requires a valid certificate.
Enhanced User Input Handling:

Improved the get_path and get_port functions for more robust user input validation.
General Code Optimization:

Simplified some repetitive patterns and used dictionary-based color management.
@KasRoudra
Copy link
Copy Markdown
Owner

Despite it's a fantastic contribution, I'd like to address some changes. First of all, the tls flag should not be true/false. You may try to take the tls filename from this argument and use that in handler.certfile. Also your changes in get_ip function has made the program hanging indefinitely if connection fails. I hope you ensure the error handling in that function. Lastly, the last bracket "]" of line containing your name should be aligned to the previous line "]"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants