Important Contributions in your repo#2
Open
viramyadav187 wants to merge 2 commits intoKasRoudra:mainfrom
Open
Conversation
Imports and Dependency Handling: Moved pyftpdlib imports inside a function to delay the import until necessary. Added an installation function to handle pyftpdlib dependency automatically. Logging: Replaced print statements with logging for better control and verbosity. TLS/SSL Support: Added an option to enable secure FTP using TLS/SSL. This requires a valid certificate. Enhanced User Input Handling: Improved the get_path and get_port functions for more robust user input validation. General Code Optimization: Simplified some repetitive patterns and used dictionary-based color management.
Owner
|
Despite it's a fantastic contribution, I'd like to address some changes. First of all, the tls flag should not be true/false. You may try to take the tls filename from this argument and use that in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Imports and Dependency Handling:
Moved pyftpdlib imports inside a function to delay the import until necessary.
Added an installation function to handle pyftpdlib dependency automatically.
Logging:
Replaced print statements with logging for better control and verbosity.
TLS/SSL Support:
Added an option to enable secure FTP using TLS/SSL. This requires a valid certificate.
Enhanced User Input Handling:
Improved the get_path and get_port functions for more robust user input validation.
General Code Optimization:
Simplified some repetitive patterns and used dictionary-based color management.