Open
Conversation
3a887b1 to
bc08688
Compare
Collaborator
|
I think this is safe, I'm a bit curious on the motivation. Schwab has recently sent an email saying:
Which will make this PR not very useful at least for this particular fund from now on. On top of paying foreign tax, the interest paid is also very low, I never received enough to justify worrying about these transactions. |
Collaborator
|
After merging, looks like the new test needs fixing |
Collaborator
|
@lgyanf any chance you can rebase and fix this ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #705
Summary
NRA Tax Adjrows without symbols and withSCHWAB1 INTas account-level interest tax.Testing
uv run pytestuv run pytest tests/general/test_calc.py::test_interest_tax_totals_are_positiveuv run pytest tests/schwab/test_schwab_interest_tax.py