#19 Improve build and provide basic test suite#21
Open
piktur wants to merge 6 commits intoKakulukian:masterfrom
Open
#19 Improve build and provide basic test suite#21piktur wants to merge 6 commits intoKakulukian:masterfrom
piktur wants to merge 6 commits intoKakulukian:masterfrom
Conversation
…lize cheerio; improve types
…proves ID normalizer
balmacefa
reviewed
Apr 19, 2024
| @@ -0,0 +1,35 @@ | |||
| import {fetchTranscript, getVideoId} from './' | |||
|
|
|||
| const ID = 'dQw4w9WgXcQ' | |||
balmacefa
reviewed
Apr 19, 2024
| duration: number; | ||
| offset: number; | ||
|
|
||
| export class YoutubeTranscriptError extends Error { |
There was a problem hiding this comment.
This can be improve using an response -:: HTTP Problem Details (RFC 7807)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses Vite for build and introduces Vitest and a test suite to give us some basic assurances.
Also opts for
node-html-parserrather thancheeriofor obvious performance benefits.