Skip to content

ignore empty command line arguments - #659

Merged
milianw merged 1 commit into
KDAB:masterfrom
GitMensch:patch-1
Nov 19, 2024
Merged

ignore empty command line arguments#659
milianw merged 1 commit into
KDAB:masterfrom
GitMensch:patch-1

Conversation

@GitMensch

Copy link
Copy Markdown
Contributor

Those can be passed by tools calling HotSpot and lead to "File '' does not exist." error messages.

One example "tool" is vscode - you can either start external programs with no arguments or with user-inputs (for example a , but if you have an empty user input (aka "just start hotspot") you get that error message.

@GitMensch
GitMensch force-pushed the patch-1 branch 2 times, most recently from 22a64b9 to 7fd1ce6 Compare June 7, 2024 18:50
@GitMensch

GitMensch commented Jun 7, 2024

Copy link
Copy Markdown
Contributor Author

Hm, thinking about that; maybe it would be nice to allow opening hotspot without "perf.data", even if it exists - this could also be triggered by the empty file "" (or a new binary option).

Thoughts?

@milianw

milianw commented Jun 15, 2024

Copy link
Copy Markdown
Collaborator

Hm, thinking about that; maybe it would be nice to allow opening hotspot without "perf.data", even if it exists - this could also be triggered by the empty file "" (or a new binary option).

Thoughts?

Up to you, if you see a need for it I'm not going to oppose a patch for that.

Comment thread src/main.cpp Outdated
@GitMensch

Copy link
Copy Markdown
Contributor Author

Hm, thinking about that; maybe it would be nice to allow opening hotspot without "perf.data", even if it exists - this could also be triggered by the empty file "" (or a new binary option).
Thoughts?

Up to you, if you see a need for it I'm not going to oppose a patch for that.

I think if we extend #660 to start on several pages (for starters at least "recording" and "open") this issue is solved. Please have a look there any comment about a possible --startPage or how you'd name an option.

@lievenhey

Copy link
Copy Markdown
Contributor

@GitMensch I wouldn't prefix the commit with chore since that should be used to dependency updates. Use feat in this case.

Those can be passed by tools calling HotSpot and lead to "File '' does not exist." error messages.
@GitMensch

Copy link
Copy Markdown
Contributor Author

done

@milianw
milianw merged commit 06cfd33 into KDAB:master Nov 19, 2024
@milianw

milianw commented Nov 19, 2024

Copy link
Copy Markdown
Collaborator

thanks!

@GitMensch
GitMensch deleted the patch-1 branch November 19, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants