Skip to content

chore: Migrate link checker from mlc to lychee (#12018)#12019

Merged
KATO-Hiro merged 7 commits intomasterfrom
#12018
Apr 26, 2026
Merged

chore: Migrate link checker from mlc to lychee (#12018)#12019
KATO-Hiro merged 7 commits intomasterfrom
#12018

Conversation

@KATO-Hiro
Copy link
Copy Markdown
Owner

No description provided.

KATO-Hiro and others added 7 commits April 26, 2026 08:12
- Replace gaurav-nelson/github-action-markdown-link-check with lycheeverse/lychee-action
- Create lychee.toml with exclude patterns from mlc_config.json
- Update scheduled check frequency: daily → weekly (Wednesday)
- Add caching support via GitHub Actions cache
- Extend check targets to include monthly_changelog/*.md, README.md, CONTRIBUTING.md
- Cache location: .github/.lychee.cache
- Update tools documentation and contributing references

mlc_config.json is no longer needed and removed.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
- Change --cache-max-age to --max-cache-age (correct CLI option)

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
cache_dir is not a valid lychee configuration field.
Lychee manages cache automatically with the 'cache = true' setting.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
The 'accept' option replaces defaults (100..=103, 200..=299), not adds to them.
Without specifying the defaults, all 2xx codes were being rejected.

Change: accept = ['429'] → accept = ['100..=103', '200..=299', '429']

This allows success codes (2xx) while also tolerating Rate Limited (429).

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Add --cache-dir .github/.lychee.cache to lychee CLI args so that:
1. lychee saves cache to the specified directory
2. GitHub Actions cache action can find and cache the directory

This resolves: 'Path Validation Error: Path(s) specified in the action
for caching do(es) not exist, hence no cache is being saved.'

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
lychee does not support --cache-dir option. Default cache location is .lycheecache.

Changes:
- Remove --cache-dir from lychee-action args
- Update actions/cache path from .github/.lychee.cache to .lycheecache
- Update .gitignore to ignore .lycheecache (not .github/.lychee.cache)

This resolves the --cache-dir option error and properly caches the cache file.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Copy link
Copy Markdown
Owner Author

@KATO-Hiro KATO-Hiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KATO-Hiro KATO-Hiro merged commit 8a18ca0 into master Apr 26, 2026
1 check passed
@KATO-Hiro KATO-Hiro deleted the #12018 branch April 26, 2026 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant