fix: handle nothing flags in writeStream to prevent unsafe_convert error#111
Open
fix: handle nothing flags in writeStream to prevent unsafe_convert error#111
Conversation
When flags parameter is nothing (the default), passing it directly to
SoapySDRDevice_writeStream causes MethodError: no method matching
unsafe_convert(::Type{Ptr{Int32}}, ::Nothing).
Fix by using out_flags as the pointer when flags is nothing,
mirroring the pattern used in readStream.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Member
|
Why not have the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When flags parameter is nothing (the default), passing it directly to SoapySDRDevice_writeStream causes MethodError: no method matching unsafe_convert(::Type{Ptr{Int32}}, ::Nothing).
Fix by using out_flags as the pointer when flags is nothing, mirroring the pattern used in readStream.
🤖 Generated with Claude Code