fix: reduce number of generated functions for typed register_symbolic (closes #1724)#1726
fix: reduce number of generated functions for typed register_symbolic (closes #1724)#1726mx-p9a wants to merge 2 commits intoJuliaSymbolics:masterfrom
Conversation
|
While I agree with the broad idea of this PR (the ability to annotate specific arguments as never being symbolic) considering any type annotation as never symbolic is not correct. For example, many functions specifically accept |
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1726 +/- ##
==========================================
- Coverage 22.92% 22.75% -0.18%
==========================================
Files 55 55
Lines 5082 5147 +65
==========================================
+ Hits 1165 1171 +6
- Misses 3917 3976 +59 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Closes #1724.
Added a test that checks the number of generated functions.
There are some test failures, but those seems unchanged from the existing test failures on
master.