Skip to content

fix: reduce number of generated functions for typed register_symbolic (closes #1724)#1726

Open
mx-p9a wants to merge 2 commits intoJuliaSymbolics:masterfrom
mx-p9a:mx/register_symbolic_counts
Open

fix: reduce number of generated functions for typed register_symbolic (closes #1724)#1726
mx-p9a wants to merge 2 commits intoJuliaSymbolics:masterfrom
mx-p9a:mx/register_symbolic_counts

Conversation

@mx-p9a
Copy link

@mx-p9a mx-p9a commented Dec 20, 2025

Closes #1724.

Added a test that checks the number of generated functions.

There are some test failures, but those seems unchanged from the existing test failures on master.

@AayushSabharwal
Copy link
Member

While I agree with the broad idea of this PR (the ability to annotate specific arguments as never being symbolic) considering any type annotation as never symbolic is not correct. For example, many functions specifically accept ::Integer. Or symbolic structs. In my opinion, a better approach would be to expose ExactType{T} (ideally under a name like NeverSymbolic{T}) as public API, allowing users to specify which arguments are never symbolic.

@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 30.55556% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 22.75%. Comparing base (e1d8802) to head (826886d).
⚠️ Report is 19 commits behind head on master.

Files with missing lines Patch % Lines
src/wrapper-types.jl 18.18% 18 Missing ⚠️
src/register.jl 50.00% 7 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1726      +/-   ##
==========================================
- Coverage   22.92%   22.75%   -0.18%     
==========================================
  Files          55       55              
  Lines        5082     5147      +65     
==========================================
+ Hits         1165     1171       +6     
- Misses       3917     3976      +59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Long compile time with register_symbolic for many arguments with only 2 untyped arguments

3 participants