Handle tuples in build_function.jl#1462
Handle tuples in build_function.jl#14625hv5hvnk wants to merge 1 commit intoJuliaSymbolics:masterfrom
Conversation
|
This would allocate though? |
|
I think so, I can probably write some tests to verify? |
|
Yes write some tests that check if the tuple route is non-allocating on simple functions. I don't think it would pass. |
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1462 +/- ##
=========================================
- Coverage 8.88% 7.70% -1.18%
=========================================
Files 51 51
Lines 4876 4943 +67
=========================================
- Hits 433 381 -52
- Misses 4443 4562 +119 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@AayushSabharwal how do this come into your changes to function building? |
Solves #1438
Added a work around to treat tuples as array and then return a tuple by converting it to a list.
ToDo: