Open
Conversation
Contributor
Benchmark Results (Julia vlts)Time benchmarks
Memory benchmarks
|
Contributor
Benchmark Results (Julia v1)Time benchmarks
Memory benchmarks
|
AayushSabharwal
requested changes
Mar 2, 2026
| where users provide abstract types that need default type parameters: | ||
| - `Complex` → `Complex{Real}` | ||
| """ | ||
| normalize_symtype(t::DataType) = t |
Member
There was a problem hiding this comment.
Is this intended as public API for downstream users to add methods to?
Author
There was a problem hiding this comment.
I wouldn't think so. This is only used as a fallback when a concrete type wasn't specified
| performance in internal operations. | ||
| """ | ||
| @inline function BSImpl.Sym{T}(name::Symbol; metadata = nothing, type, shape = default_shape(type), unsafe = false) where {T} | ||
| type = normalize_symtype(type) |
Member
There was a problem hiding this comment.
This code path is very performance sensitive, and this change would add an unavoidable dynamic dispatch.
Author
There was a problem hiding this comment.
would you be okay with doing it in sym_from_parse_result instead? So working on result[:type] = :Complex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
UnionAlltypes likeComplexdo not have a good default constructor.Which would lead to:
The function
normalize_symtypehandles this case, so that nowComplexdefaults toComplex{Real}.I also updated the readme example, it wasn't working.