Adjust test for #185 to not rely on old reduce(vcat, ...) behavior for single element collections #335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r single element collections
nalimilan
approved these changes
Jan 2, 2026
andreasnoack
added a commit
that referenced
this pull request
Jan 4, 2026
* Update to [email protected] * Test on pre instead of nightly * Update runtests.jl Co-authored-by: Milan Bouchet-Valat <[email protected]> * Make coeftable(::MatrixTerm) always return Vector{String} (#334) * Adjust test for #185 to not rely on old reduce(vcat, ...) behavior for single element collections (#335) * Adjust test for #185 to not rely on old reduce(vcat, ...) behavior for single element collections * Run CI on all PRs --------- Co-authored-by: Milan Bouchet-Valat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the failure on 1.13. The root cause is once again the new behavior of
reduce(vcat,...)for single-element collections discussed in #334. Here, the solution is just to adjust the test that relied on the old behavior.