Add coefplot and groupedcoefplot for StatisticalModel#491
Open
getzze wants to merge 10 commits intoJuliaPlots:masterfrom
Open
Add coefplot and groupedcoefplot for StatisticalModel#491getzze wants to merge 10 commits intoJuliaPlots:masterfrom
getzze wants to merge 10 commits intoJuliaPlots:masterfrom
Conversation
Author
sethaxen
requested changes
May 22, 2022
Member
sethaxen
left a comment
There was a problem hiding this comment.
Thanks for the PR! I'm happy to have this functionality in this package. It's a lot of code though, so we'll probably need a few rounds of review.
A few general comments first:
- I know StatsPlots doesn't consistently do this (yet), but it would make the code more readable if the function calls/types were prefixed with the package name where they're defined (or implemented, if we rely on the implementation)
- Can you make your utility function names more descriptive? This will make it easier for me to follow the code.
- You've essentially implemented a forest plot. This is generally useful apart from plotting coefficients of statistical models. Would it make sense to refactor to a
forestplotprimitive and acoefplotthat extracts the coefficients and passes them toforestplot?
Author
|
Hi, sorry for the long delay. I had some time so I refactored the code, let me know if it is clearer. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #491 +/- ##
===========================================
+ Coverage 26.52% 37.77% +11.24%
===========================================
Files 20 21 +1
Lines 1248 1660 +412
===========================================
+ Hits 331 627 +296
- Misses 917 1033 +116 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


The new dependency is minimal (StatsModels), test dependencies are a bit bigger (CategoricalArrays, DataFrames, GLM).
Tested with the gr, pyplot and plotly backends.
It was tested and working with GLM.jl, MixedModels.jl and RobustModels.jl models. I don't know other packages that use the StatsModels API.