Skip to content

Add ::Tuple assertion in fzero to prevent invalidation cascade #1553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ViralBShah merged 2 commits into from
Feb 28, 2026
Merged

Add ::Tuple assertion in fzero to prevent invalidation cascade #1553

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da17d24
Add ::Tuple assertion in fzero to prevent invalidation cascade
ChrisRackauckas Feb 27, 2026
4176cdb
Merge branch 'master' into fix-fzero-invalidation
jishnub Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/structuredbroadcast.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,13 @@ fzero(S::StructuredMatrix) = Some(zero(eltype(S)))
fzero(::StructuredMatrix{<:AbstractMatrix{T}}) where {T<:Number} = Some(haszero(T) ? zero(T)*I : nothing)
fzero(x) = nothing
function fzero(bc::Broadcast.Broadcasted)
args = map(fzero, bc.args)
# Type-assert to prevent inference from widening the result type to AbstractArray.
# Broadcasted.args is always <: Tuple by construction, but when the Broadcasted type
# parameter is not fully known (e.g., Broadcasted{StructuredMatrixStyle{T} where T}),
# inference may widen args, causing any(isnothing, args) to create a cached
# MethodInstance any(::typeof(isnothing), ::AbstractArray) that is invalidated by
# any package defining any(f, ::AbstractArraySubtype).
args = map(fzero, bc.args)::Tuple
return any(isnothing, args) ? nothing : Some(bc.f(map(something, args)...))
end

Expand Down