Skip to content

Fix iteration for 0-dimensional disk arrays #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sethaxen wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix iteration for 0-dimensional disk arrays #293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7cb9b75
test: Add breaking iter test for 0-dim arrays
sethaxen Feb 20, 2026
1b54d76
fix: Fix iteration for 0-dim arrays
sethaxen Feb 20, 2026
0ebc898
chore: Increment patch number
sethaxen Feb 20, 2026
9bcc11a
fix: Model iteration on method for Arrays
sethaxen Feb 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "DiskArrays"
uuid = "3c3547ce-8d99-4f5e-a174-61eb10b00ae3"
authors = ["Fabian Gans <fgans@bgc-jena.mpg.de>"]
version = "0.4.19"
version = "0.4.20"

[deps]
ConstructionBase = "187b0558-2788-49d3-abe0-74a17ed4e7c9"
Expand Down
2 changes: 2 additions & 0 deletions src/iterator.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,8 @@ end
end
end
end
_iterate_disk(a::AbstractArray{<:Any,0}, i=1) = i == 1 ? (@inbounds a[i], 2) : nothing

@noinline function _iterate_disk(a)
# Get the indices for each chunk of data
blockinds = BlockedIndices(eachchunk(a))
Expand Down
9 changes: 9 additions & 0 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,6 +379,15 @@ end
end
end

# https://github.com/JuliaIO/DiskArrays.jl/issues/289
@testset "iteration works for 0-dimensional arrays" begin
a = UnchunkedDiskArray(fill(42))
@test iterate(a) == (42, 2)
@test iterate(a, 1) == (42, 2)
@test iterate(a, 2) === nothing
@test collect(a) == fill(42)
end

@testset "Views" begin
a = AccessCountDiskArray(zeros(Int, 4, 5, 1))
test_view(a)
Expand Down
Loading