Skip to content

Fix a few remaining issues and allow setting the scene as a property#7

Merged
barche merged 7 commits intomasterfrom
scenesupport
Jul 30, 2025
Merged

Fix a few remaining issues and allow setting the scene as a property#7
barche merged 7 commits intomasterfrom
scenesupport

Conversation

@barche
Copy link
Copy Markdown
Collaborator

@barche barche commented Jul 29, 2025

I think after merging this a release is in order :)

@steffenhaug
Copy link
Copy Markdown
Collaborator

Nice work!

As far as releasing go, are there any more formal requirements to work out? For instance, is a test suite and docs formally required? Or can docs live in the QML package so it's all in one place? We probably also ought to add a license; I would say MIT makes the most sense since the original code i ripped from your repo is MIT, and it is also my favorite license anyway.

Before releasing, it would also make sense to add you as an author in Project.toml. After all, most of the original code was written by you even though it was committed by me in this repo, and you have done all the work of updating it, so you should get credit.

@barche barche force-pushed the scenesupport branch 4 times, most recently from fa3e5f2 to 6d04b21 Compare July 30, 2025 19:02
@barche barche merged commit 1c94399 into master Jul 30, 2025
3 of 11 checks passed
@barche barche deleted the scenesupport branch July 30, 2025 20:32
@barche
Copy link
Copy Markdown
Collaborator Author

barche commented Jul 30, 2025

Thanks for the useful suggestions, all should be OK now. I'll trigger a release, there will then be a 3 day waiting period.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants