Skip to content

Fix StackOverflowError for LLA with non-Number arguments #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
asinghvi17 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix StackOverflowError for LLA with non-Number arguments #112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/points.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ struct LLA{T <: Number}
lon::T
alt::T
end
LLA(lat, lon, alt=zero(lat)) = LLA(promote(lat, lon, alt)...)
LLA(lat::Number, lon::Number, alt::Number=zero(lat)) = LLA(promote(lat, lon, alt)...)
LLA(;lat=NaN,lon=NaN,alt=0.0) = LLA(lat,lon,alt) # Constructor that is idependent of storage order

Base.show(io::IO, lla::LLA) = print(io, "LLA(lat=$(lla.lat)°, lon=$(lla.lon)°, alt=$(lla.alt))") # Maybe show to nearest mm, or 6 decimel places?
Expand Down
1 change: 1 addition & 0 deletions test/points.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
@test LLA(lat = 1., lon = 1., alt = 0.) == lla
@test LLA(1//1, 1, 0.) == lla
@test LLA(1, 1) == LLA{Int}(1, 1, 0)
@test_throws MethodError LLA(missing, missing)

latlon = LatLon(1., 1.)
@test LatLon(lat = 1., lon = 1.) == latlon
Expand Down
Loading