guard against trait type piracy in a dependent package#157
Open
nsajko wants to merge 2 commits intoJuliaCollections:masterfrom
Open
guard against trait type piracy in a dependent package#157nsajko wants to merge 2 commits intoJuliaCollections:masterfrom
nsajko wants to merge 2 commits intoJuliaCollections:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #157 +/- ##
==========================================
+ Coverage 71.16% 71.49% +0.32%
==========================================
Files 8 8
Lines 437 442 +5
==========================================
+ Hits 311 316 +5
Misses 126 126 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nsajko
force-pushed
the
guard_against_trait_type_piracy_in_a_dependent_package
branch
3 times, most recently
from
13728a5 to
af7eee8
Compare
Member
Author
|
This is how The slurp stuff is presumably there to help inference somehow. I don't think it's important to have that. |
Prevent dependent packages from commiting type piracy easily and
unintentionally when defining an AbstractTrees trait for all subtypes
of a type. Specifically: the bottom type, `Union{}`, is a subtype of
each type, so add a method for the bottom type for each AbstractTrees
trait. This method will take precedence over sane methods in dependent
packages, thus preventing spurious type piracy.
nsajko
force-pushed
the
guard_against_trait_type_piracy_in_a_dependent_package
branch
from
af7eee8 to
ecd0e9b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent dependent packages from commiting type piracy easily and unintentionally when defining an AbstractTrees trait for all subtypes of a type. Specifically: the bottom type,
Union{}, is a subtype of each type, so add a method for the bottom type for each AbstractTrees trait. This method will take precedence over sane methods in dependent packages, thus preventing spurious type piracy.