MSVC, gcc, clang compiler warning fixes#409
Open
pattakosn wants to merge 10 commits intoJoeyDeVries:masterfrom
Open
MSVC, gcc, clang compiler warning fixes#409pattakosn wants to merge 10 commits intoJoeyDeVries:masterfrom
pattakosn wants to merge 10 commits intoJoeyDeVries:masterfrom
Conversation
this silences warning for uninitialized variable use and safe guards against wrong data used
i do not know what was the original intention of this code but as the warning said, it returned a reference to local data. As it was not really used anywhere, i remove it.
I thought compilers today were smart enough to recognize that there is no return after an assert(0) but apparently this is not so.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, i built it on windows with MSVC and on linux with gcc and clang and i had several compiler warnings.
They are not important but i find it very distracting when i am trying to find my own actual errors so i fixed those.
Or I hope i fixed them, i do not know if you like those fixes.