Skip to content

fix: Fix DeprecationWarning: Module.issuer: Use new ModuleGraph API - #423

Open
Malik Bensabre (MalikBen) wants to merge 1 commit into
JetBrains:masterfrom
MalikBen:fix-deprecated-msg-webpack5
Open

fix: Fix DeprecationWarning: Module.issuer: Use new ModuleGraph API#423
Malik Bensabre (MalikBen) wants to merge 1 commit into
JetBrains:masterfrom
MalikBen:fix-deprecated-msg-webpack5

Conversation

@MalikBen

Copy link
Copy Markdown

What kind of change does this PR introduce? (bugfix, feature, docs update, improvement)
Removes warning by using ModuleGraph in case of webpack version >= 5
What is the current behavior? (You can also link to an open issue here)
webpack5 build throws a DeprecationWarning
[DEP_WEBPACK_MODULE_ISSUER] DeprecationWarning: Module.issuer: Use new ModuleGraph API
See #418
What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change?

Please check if the PR fulfills contributing guidelines

@zhongzhong0505

Copy link
Copy Markdown

checks failed , Malik Bensabre (@MalikBen)

@dmnsgn

Copy link
Copy Markdown
Contributor

Malik Bensabre (@MalikBen)

Looks like test for Env "webpack-2" are failing. Does webpack 2 exports version? If not then can you try changing:

const isWebpackGreaterThan5 = version[0] >= 5;

to

const isWebpackGreaterThan5 = version && version[0] >= 5;

@flyyang

Copy link
Copy Markdown

ping Malik Bensabre (@MalikBen)

1 similar comment
@liuliangsir

Copy link
Copy Markdown

ping Malik Bensabre (@MalikBen)

@b-e-r-t-o

Copy link
Copy Markdown

Pete Nelson (@pbn04001) can I open a new PR to fix this warning?

@d3x42

Copy link
Copy Markdown
Contributor

ats (@b-e-r-t-o) Yes, you can

@MalikBen

Copy link
Copy Markdown
Author

Hi, I'm sorry I was receiving all the e-mails in my spam box, is this issue fixed ? Should I close it ?

@Eli-Black-Work

Copy link
Copy Markdown

For what it's worth, I'm no longer seeing this issue. Probably best to wait until a few others weight in before closing it, though, IMHO 🙂

@Eli-Black-Work

Copy link
Copy Markdown

Wait, nvm, I was testing with an outdated version of svg-sprite-loader. Please disregard my answer 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants